On Wed, 3 Jun 2020 14:58:33 +0200 Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote: > Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> wrote on Tue, 2 Jun > 2020 18:21:57 +0200: > > > On Tue, 2 Jun 2020 16:31:24 +0200 > > Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote: > > > > > +void nand_ecc_read_user_conf(struct nand_device *nand) > > > > This function is not introduced in this patch, but I'm commenting here. > > Looks like it only operates on an OF node, so how about naming it > > of_get_nand_ecc_config(). > > of_get_nand_ecc_user_config()? I'd like to mention "user" because > "config" is way too vague given the number of possible configuration > sources. Works for me. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/