Re: [PATCH v5 16/28] mtd: rawnand: timings: Use default values for tPROG_max and tBERS_max

[Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>]

On Wed, 27 May 2020 09:22:49 +0200
Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:

> Hi Miquel,
> 
> Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote on Wed, 27 May 2020
> 09:17:58 +0200:
> 
> > Hi Boris,
> > 
> > Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> wrote on Tue, 26 May
> > 2020 23:25:30 +0200:
> >   
> > > On Tue, 26 May 2020 21:17:13 +0200
> > > Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:
> > >     
> > > > The ONFI parameter page of a chip might define more fine grained
> > > > tPROG_max and tBERS_max. When we do not have this information, we
> > > > default to the highest possible values (they are maxima anyway).
> > > > 
> > > > There is no point setting these fields at runtime, so explicitly move
> > > > these defaults to the main ONFI SDR timings structure.      
> > > 
> > > Okay, now I see why you're doing that: you want to return the mode 0
> > > entry directly, and it makes sense, but it should be explained in the
> > > commit message.    
> > 
> > Okay I will mention it in the other commit message, and perhaps move
> > the comment about them as well so that it does not get lost.
> > 
> > I can also assign these timings manually for mode 0 in the helper you
> > requested.  
> 
> Actually I don't like this idea which would mean changing the content
> of the timings structure itself...

Me neither, they should stay const.

> 
> I would prefer to move these 4 values to the structure (as I already
> do) plus moving the comment explaining the derivations.
> 

Agreed.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/