Re: [PATCH v2 1/2] mtd: rawnand: Add a helper for testing data interface

[Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>]

On Wed, 20 May 2020 14:52:52 +0000
Rickard X Andersson <Rickard.Andersson@xxxxxxxx> wrote:

> Hi Miquel,
> 
> Comments on two of your comments. (I am fine with all the other comments.)
> 
> > > +     /*
> > > +      * Pass NAND_DATA_IFACE_CHECK_ONLY to only check if the
> > > +      * controller supports the requested timings.
> > > +      */
> > > +     ret = chip->controller->ops->setup_data_interface(chip,
> > > +                                              NAND_DATA_IFACE_CHECK_ONLY,
> > > +                                              &chip->data_interface);  
> >
> > Could you align these lines to the opened parenthesis?  
> 
> Then the lines will have 80+ characters.

Just add a local ops var.

	const struct nand_controller_ops *ops = chip->controller->ops;

	ret = ops->setup_data_interface(chip, NAND_DATA_IFACE_CHECK_ONLY,
					 &chip->data_interface);

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/