SV: [PATCH v2 1/2] mtd: rawnand: Add a helper for testing data interface

[Rickard X Andersson <Rickard.Andersson@xxxxxxxx>]

Hi Miquel,

Comments on two of your comments. (I am fine with all the other comments.)

> > +     /*
> > +      * Pass NAND_DATA_IFACE_CHECK_ONLY to only check if the
> > +      * controller supports the requested timings.
> > +      */
> > +     ret = chip->controller->ops->setup_data_interface(chip,
> > +                                              NAND_DATA_IFACE_CHECK_ONLY,
> > +                                              &chip->data_interface);
>
> Could you align these lines to the opened parenthesis?

Then the lines will have 80+ characters.

> > @@ -994,9 +1020,6 @@ static int nand_choose_data_interface(struct nand_chip *chip)
> >       if (chip->parameters.onfi) {
> >               modes = chip->parameters.onfi->async_timing_mode;
> >       } else {
> > -             if (!chip->default_timing_mode)
> > -                     return 0;
> > -
>
> This should not be removed

Then onfi_fill_data_interface would not be called for default_timing_mode 0. (In case we have called chip->ops.choose_data_interface and got an error.).

BR,
Rickard

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/