Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> wrote on Tue, 19 May 2020 15:01:57 +0200: > On Tue, 19 May 2020 14:30:32 +0200 > Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote: > > > There are controllers not able to just read data cycles on the > > bus. There are controllers not able to do a change column. > > > > If we want to support both, we need to check which operation is > > supported first. This is the exact same mechanism that is in use for > > parameter page reads (ONFI/JEDEC) as the same problem occurs. > > > > Speed testing does not show any throughput penalty so we do not > > optimize more than that. However it is likely that, in the future, a > > more robust and exhaustive test will run at boot time to avoid > > re-checking what is supported and what is not at every call. > > > > Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx> > > Reviewed-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> > > --- > > > > Changes in v2: > > * Added a comment before each check which is a condensate of the > > commit message. > > I don't see those comments :P. Do you think I forgot a "git add ."?... Let me resend this one. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/