Hello, This is a deep rework of Naga's Arasan NAND controller driver. This version is the final version and works with software ECC. It relies on a previous series called "Supporting restricted NAND controllers" that brings more flexibility to the NAND with the goal to support restricted controllers like this one. Cheers, Miquèl Changes in v5: * Added a FIXME and two TODO comments in the code, explaining how/hy the NAND core should be extended. * Created a real function that returns the packet size and number, or an error if the exact requested amount cannot be reached. * Created a new helper to check if an operation is actually supported or not. Used the above new helper for checking the validity of an ->exec_op() operation on demand. * Collected Rob's Reviewed-by tag. Changes in v4: * Collected Reviewed-by tags. * Dropped Ivan from the list (did not find his contact). * Wrapped commit log. * Fixed typos in the commit logs/comments. * Took authorship of all patches. * Added more details on the BCH changes. * Documented the new bch_control entry. * Made the swap bit calls conditionals in bch_encode to avoid penalizing people that do not use it. * Patched bch_init() to take an extra argument. * Dropped calls to nand_release(), use the construction proposed by Boris instead. * Dropped a useless NFC struct field. * Added a comment on not having an interrupt for RB. * Checked the number of steps requested is compatible with the controller limitations. * Reworked anfc_exec_op as suggested to treat the check_only argument another way. * Change the comment stating that the controller has only one CS. * Clarified the interrupts signals vs. interrupt status bits. Changes in v3: * Prefix specific clock definitions with XLNX as they do not apply for any other SoC and are attached to a single compatible. * Used field getters/setters as defined in bitfield.h. * Force casting to u32 before shifting u8 values by 8 16 or 24 bits. * Comply with the recent core changes and select manually nand_monolithic_read/write_page_raw() helpers. * Add MAINTAINER patch. * Add a bit extraction helper in the core. * Rename BCH functions. * Add a swapping bit mechanism to BCH. * Support the hardware ECC engine. Changes in v2: * Working ->exec_op() implementation relying on core changes. * Dropped the ECC support for now, will be part of another series if this patch is accepted. Miquel Raynal (8): lib/bch: Rework a little bit the exported function names lib/bch: Allow easy bit swapping mtd: rawnand: Ensure the number of bitflips is consistent mtd: rawnand: Add nand_extract_bits() MAINTAINERS: Add Arasan NAND controller and bindings dt-bindings: mtd: Document ARASAN NAND bindings mtd: rawnand: arasan: Add new Arasan NAND controller mtd: rawnand: arasan: Support the hardware BCH ECC engine .../bindings/mtd/arasan,nand-controller.yaml | 63 + MAINTAINERS | 7 + drivers/mtd/devices/docg3.c | 10 +- drivers/mtd/nand/raw/Kconfig | 7 + drivers/mtd/nand/raw/Makefile | 1 + drivers/mtd/nand/raw/arasan-nand-controller.c | 1297 +++++++++++++++++ drivers/mtd/nand/raw/nand_base.c | 52 +- drivers/mtd/nand/raw/nand_bch.c | 10 +- include/linux/bch.h | 11 +- include/linux/mtd/rawnand.h | 4 + lib/bch.c | 152 +- 11 files changed, 1550 insertions(+), 64 deletions(-) create mode 100644 Documentation/devicetree/bindings/mtd/arasan,nand-controller.yaml create mode 100644 drivers/mtd/nand/raw/arasan-nand-controller.c -- 2.20.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/