Re: [PATCH v4 11/13] mtd: rawnand: Expose monolithic read/write_page_raw() helpers

[Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>]

On Mon, 4 May 2020 12:37:40 +0200
Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:

> Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> wrote on Mon, 4 May
> 2020 12:35:01 +0200:
> 
> > On Mon,  4 May 2020 11:52:35 +0200
> > Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:
> >   
> > >  /**
> > >   * nand_write_page_raw_syndrome - [INTERN] raw page write function
> > >   * @chip: nand chip info structure
> > > diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
> > > index 70380c91731c..830e05dd1e1d 100644
> > > --- a/include/linux/mtd/rawnand.h
> > > +++ b/include/linux/mtd/rawnand.h
> > > @@ -1328,13 +1328,17 @@ int nand_read_oob_std(struct nand_chip *chip, int page);
> > >  int nand_get_set_features_notsupp(struct nand_chip *chip, int addr,
> > >  				  u8 *subfeature_param);
> > >  
> > > -/* Default read_page_raw implementation */
> > > +/* Default read_page_raw implementations */    
> > 
> > I thought we agreed on dropping the "Default" here
> >   
> > >  int nand_read_page_raw(struct nand_chip *chip, uint8_t *buf, int oob_required,
> > >  		       int page);
> > > +int nand_monolithic_read_page_raw(struct nand_chip *chip, uint8_t *buf,
> > > +				  int oob_required, int page);
> > >  
> > > -/* Default write_page_raw implementation */
> > > +/* Default write_page_raw implementations */    
> > 
> > and here :).  
> 
> I completely forgot about that.
> 
> If the rest is fine, I'll just resend this one (or the last patches).

Or fix when applying.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/