Re: [PATCH 1/2] mtd: spi-nor: Uniformize the return value in spi_nor_*_ready()

[Vignesh Raghavendra <vigneshr@xxxxxx>]

On 21/04/20 12:01 pm, Tudor.Ambarus@xxxxxxxxxxxxx wrote:
> From: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>
> 
> spi_nor_ready() returns 1 if ready, 0 if not ready and -errono on errors.

s/-errono/-errno

With that:

Reviewed-by: Vignesh Raghavendra <vigneshr@xxxxxx>

> Do the same in all the spi_nor_*_ready() children.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>
> ---
>  drivers/mtd/spi-nor/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
> index cc68ea84318e..9dcc53bda8b0 100644
> --- a/drivers/mtd/spi-nor/core.c
> +++ b/drivers/mtd/spi-nor/core.c
> @@ -640,7 +640,7 @@ static int spi_nor_fsr_ready(struct spi_nor *nor)
>  		return -EIO;
>  	}
>  
> -	return nor->bouncebuf[0] & FSR_READY;
> +	return !!(nor->bouncebuf[0] & FSR_READY);
>  }
>  
>  /**
> 

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/