Re: [PATCH 03/10] mtd: rawnand: Rename a NAND chip option

[Miquel Raynal <miquel.raynal@xxxxxxxxxxx>]

Hi Boris,

Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> wrote on Sat, 25 Apr
2020 10:39:56 +0200:

> On Fri, 24 Apr 2020 19:36:24 +0200
> Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:
> 
> > NAND controller drivers can set the NAND_USE_BOUNCE_BUFFER flag to a
> > chip 'option' field. With this flag, the core is responsible of
> > providing DMA-able buffers.
> > 
> > The current behavior is to not force the use of a bounce buffer when
> > the core thinks this is not needed. So in the end the name is a bit
> > misleading, because in theory we will always have a DMA buffer but in
> > practice it will not always be a bounce buffer.
> > 
> > Rename this flag NAND_USE_DMA_BUFFER to be more accurate.  
> 
> I would suggest renaming it NAND_CONTROLLER_NEEDS_DMAABLE_BUFFER or
> NAND_CONTROLLER_USES_DMA, and maybe we should introduce NAND controller
> flags (nand_controller.flags) instead of hijacking the NAND chip flags.

Agreed, in fact I would like to entirely rework all the NAND flags. I
will do it in a separate series.


Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/