Re: [PATCH 6/9] mtd: rawnand: bcm47xx: Get rid of the legacy implementation

[Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>]

On Mon, 27 Apr 2020 19:19:22 +0200
Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:

> Hi Boris,
> 
> Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> wrote on Sun, 19 Apr
> 2020 14:51:37 +0200:
> 
> > Now that exec_op() is implemented we don't need to implement all those
> > legacy hooks, which simplifies the code quite a bit.
> > 
> > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>
> > ---
> >  .../nand/raw/bcm47xxnflash/bcm47xxnflash.h    |   6 -
> >  .../mtd/nand/raw/bcm47xxnflash/ops_bcm4706.c  | 315 ------------------
> >  2 files changed, 321 deletions(-)  
> 
> Love the diffstat!

Well, the real diffstat is in the cover letter, but yes, it's nice to
see how exec_op() can simplify things quite a bit. I'm more impressed
by the readability improvement though ;-).

> 
> Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> 
> Thanks,
> Miquèl


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/