Re: ubifs: mounting fails due to error in orphan file handling

[Richard Weinberger <richard.weinberger@xxxxxxxxx>]

On Fri, Feb 7, 2020 at 11:18 AM Jef Driesen <jef.driesen@xxxxxxx> wrote:
>
> On 2/5/20 5:17 PM, Steve deRosier wrote:
> > Looking at the comment in the mentioned commit: "This corner case
> > needs to get addressed in the orphans subsystem too."
> >
> > Was it addressed?  Was there a second commit for that?  If so, is it
> > in your tree?
>
> I don't see anything relevant showing up with a quick:
>
> git log ee1438ce5dc4d67dd8dd1ff51583122a61f5bd9e..master -- fs/ubifs/
>
> The only fix that refers to that particular commit is this one:
>
> commit 10256f000932f12596dc043cf880ecf488a32510
> Author: Zhihao Cheng <chengzhihao1@xxxxxxxxxx>
> Date:   2019-10-29 20:58:23 +0800
>
>      ubifs: do_kill_orphans: Fix a memory leak bug
>
>      If there are more than one valid snod on the sleb->nodes list,
>      do_kill_orphans will malloc ino more than once without releasing
>      previous ino's memory. Finally, it will trigger memory leak.
>
>      Fixes: ee1438ce5dc4 ("ubifs: Check link count of inodes when...")
>      Signed-off-by: Zhihao Cheng <chengzhihao1@xxxxxxxxxx>
>      Signed-off-by: zhangyi (F) <yi.zhang@xxxxxxxxxx>
>      Signed-off-by: Richard Weinberger <richard@xxxxxx>
>
> But that's about fixing a memory leak, and not the on-disk data.
>
> > Beyond that, no ideas, it's not a chunk of code I am familiar with.

I send a fix for this before I started traveling:
[PATCH] ubifs: Fix ubifs_tnc_lookup() usage in do_kill_orphans()

Digging currently thought all my mails....

-- 
Thanks,
//richard

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/