Re: [PATCH 4/8] mtd: Add support for emulated SLC mode on MLC NANDs

[Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>]

On Thu, 9 Jan 2020 19:39:42 +0100 (CET)
Richard Weinberger <richard@xxxxxx> wrote:

> Miquel,
> 
> ----- Ursprüngliche Mail -----
> >> I suggest giving a name which indicates that we are actually emulating
> >> an SLC. Maybe MTD_SLC_EMULATION?
> >> Some MLC NANDs support SLC mode in hardware, MTD_MLC_IN_SLC_MODE reads like
> >> this feature.  
> > 
> > You're right. What about MTD_SLC_ON_MLC_EMULATION?  
> 
> Makes sense.
>   
> >> The name is misleading. We don't do OOB IO on a SLC NAND,
> >> we emulate SLC.  

We should really replace those mtd_oob_ prefixes by something
more accurate like mtd_io_ at some point (those helpers can do more than
just read/write the OOB region).

> > 
> > What would you recommend? mtd_oob_io_emul_slc?  
> 
> Yes. Let's use "emul_slc" to indicate SLC emulation.

How about mtd_io_emulated_slc()?

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/