Re: [PATCH] mtd: no need to check return value of debugfs_create functions

[Miquel Raynal <miquel.raynal@xxxxxxxxxxx>]

Hi Greg,

Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote on Thu, 7 Nov
2019 10:15:18 +0100:

> On Thu, Nov 07, 2019 at 10:09:44AM +0100, Miquel Raynal wrote:
> > Hi Greg,
> > 
> > Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote on Thu, 7 Nov
> > 2019 09:51:11 +0100:
> >   
> > > When calling debugfs functions, there is no need to ever check the
> > > return value.  The function can work or not, but the code logic should
> > > never do something different based on this.  
> > 
> > I didn't know about this. Is this something new or has it been the rule
> > since the beginning? In the  case, don't we need a Fixes tag here?  
> 
> It's been the way always, but as of a few kernel releases ago, debugfs
> is even more "fault-tolerant" of stuff like this.
> 
> And there's no need for a "Fixes:" as this is just work to clean up the
> debugfs api and usage (I have a lot more work to do after these types of
> changes.)

Ok, thanks for the clarification.

Cheers!
Miquèl

> 
> >   
> > > Cc: David Woodhouse <dwmw2@xxxxxxxxxxxxx>
> > > Cc: Brian Norris <computersforpeace@xxxxxxxxx>
> > > Cc: Marek Vasut <marek.vasut@xxxxxxxxx>
> > > Cc: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> > > Cc: Richard Weinberger <richard@xxxxxx>
> > > Cc: Vignesh Raghavendra <vigneshr@xxxxxx>
> > > Cc: Artem Bityutskiy <dedekind1@xxxxxxxxx>
> > > Cc: linux-mtd@xxxxxxxxxxxxxxxxxxx
> > > Cc: linux-kernel@xxxxxxxxxxxxxxx
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>  
> > 
> > [...]
> >   
> > > +
> > > +	d->dfs_emulate_io_failures = debugfs_create_file("tst_emulate_io_failures",
> > > +							 S_IWUSR, d->dfs_dir,
> > > +							 (void *)ubi_num,
> > > +							 &dfs_fops);
> > > +
> > > +	d->dfs_emulate_power_cut = debugfs_create_file("tst_emulate_power_cut",
> > > +						       S_IWUSR, d->dfs_dir,
> > > +						       (void *)ubi_num,
> > > +						       &dfs_fops);  
> > 
> > Nitpick: I think we miss an empty line here. I can fix it when applying.  
> 
> Ah, oops, sorry about that.
> 
> thanks,
> 
> greg k-h


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/