Re: [PATCH 2/2] mtd: cfi_cmdset_0002: fix delayed error detection on HyperFlash

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

           if (chipstatus & CFI_SR_SLSB)
               pr_err("%s sector write protected, status %lx\n",
                      map->name, chipstatus);
+        return 1;
Is it okay to be returned 1 for the errors CFI_SR_WBASB and CFI_SR_SLSB also?
Before the change only CFI_Well, SR_ESB and CFI_SR_PSB were checked by chip_good().
    Well, pr_err() calls above spoke for themselves: all bitmask 0x3a was considered
the error bits. But I can change that back to just ESB/PSB if preferred.
It was mentioned before as it is enough to see if ESB or PSB is set to know if write or erase failed.
    It's better to remove the diff you're not commenting to.

Noted it.

Regards,
Ikegami


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/



[Index of Archives]     [LARTC]     [Bugtraq]     [Yosemite Forum]     [Photo]

  Powered by Linux