On Tue, 24 Sep 2019 07:46:03 +0000 <Tudor.Ambarus@xxxxxxxxxxxxx> wrote: > From: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx> > > Rename nor->params to nor->flash for a clearer separation > between the controller and flash operations. Hm, I'm not sure 'flash' is clearer than 'params', and the spi_nor object is supposed to represent the NOR chip anyway, so it was pretty clear to me that nor->params were the NOR flash parameters not the NOR controller ones. If I had anything to change it would be s/params/properties/ (and s/spi_nor_flash_parameter/spi_nor_properties/) since those parameters look like immutable information discovered during the NOR detection, but I'm nitpicking here. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
Re: [PATCH v2 04/22] mtd: spi-nor: Rename nor->params to nor->flash
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v2 04/22] mtd: spi-nor: Rename nor->params to nor->flash
- From: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>
- Date: Thu, 10 Oct 2019 09:05:24 +0200
- Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, vigneshr@xxxxxx, geert+renesas@xxxxxxxxx, andrew@xxxxxxxx, richard@xxxxxx, linux-kernel@xxxxxxxxxxxxxxx, vz@xxxxxxxxx, marek.vasut@xxxxxxxxx, jonas@xxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, joel@xxxxxxxxx, miquel.raynal@xxxxxxxxxxx, matthias.bgg@xxxxxxxxx, linux-mediatek@xxxxxxxxxxxxxxxxxxx, computersforpeace@xxxxxxxxx, dwmw2@xxxxxxxxxxxxx, linux-aspeed@xxxxxxxxxxxxxxxx
- In-reply-to: <20190924074533.6618-5-tudor.ambarus@microchip.com>
- Organization: Collabora
- References: <20190924074533.6618-1-tudor.ambarus@microchip.com> <20190924074533.6618-5-tudor.ambarus@microchip.com>
- Follow-Ups:
- Re: [PATCH v2 04/22] mtd: spi-nor: Rename nor->params to nor->flash
- From: Tudor.Ambarus
- Re: [PATCH v2 04/22] mtd: spi-nor: Rename nor->params to nor->flash
- References:
- [PATCH v2 00/22] mtd: spi-nor: Quad Enable and (un)lock methods
- From: Tudor.Ambarus
- [PATCH v2 04/22] mtd: spi-nor: Rename nor->params to nor->flash
- From: Tudor.Ambarus
- [PATCH v2 00/22] mtd: spi-nor: Quad Enable and (un)lock methods
- Prev by Date: Re: [PATCH v2 03/22] mtd: spi-nor: cadence-quadspi: Fix cqspi_command_read() definition
- Next by Date: Re: [PATCH v2 05/22] mtd: spi-nor: Rework read_sr()
- Previous by thread: [PATCH v2 04/22] mtd: spi-nor: Rename nor->params to nor->flash
- Next by thread: Re: [PATCH v2 04/22] mtd: spi-nor: Rename nor->params to nor->flash
- Index(es):
 |