Re: [PATCH] Add support for Macronix NAND randomizer

[Miquel Raynal <miquel.raynal@xxxxxxxxxxx>]

Hi Mason,

masonccyang@xxxxxxxxxxx wrote on Thu, 29 Aug 2019 17:07:51 +0800:

> Hi Miquel, 
> 
> 
> > > 
> > > If subpage write not available with hardware ECC, for example,
> > > NAND chip options NAND_NO_SUBPAGE_WRITE be set in driver and
> > > randomizer function is recommended for high-reliability.
> > > Driver checks byte 167 of Vendor Blocks in ONFI parameter page table
> > > to see if this high-reliability function is supported.
> > >   
> > 
> > You did not flagged this patch as a v2 and forgot about the changelog.
> > You did not listen to our comments in the last version neither. I was
> > open to a solution with a specific DT property for warned users but I
> > don't see it coming.
> >   
> 
> Based on your comments by specific DT property for randomizer support.
> to add a new property in children nodes:
> 
> i.e,.
> 
> nand: nand-controller@43c30000 {
> 
>                 nand@0 {
>                         reg = <0>;
>                         nand-reliability = "randomizer";

                          mxic,enable-randomizer-otp;

Would be better (with the proper documentation in the bindings).


Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/