Hi Tudor, > -----Original Message----- > From: Tudor.Ambarus@xxxxxxxxxxxxx <Tudor.Ambarus@xxxxxxxxxxxxx> > Sent: Wednesday, July 31, 2019 6:37 PM > To: Naga Sureshkumar Relli <nagasure@xxxxxxxxxx>; boris.brezillon@xxxxxxxxxxxxx; > marek.vasut@xxxxxxxxx; vigneshr@xxxxxx > Cc: richard@xxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-mtd@xxxxxxxxxxxxxxxxxxx; > miquel.raynal@xxxxxxxxxxx; computersforpeace@xxxxxxxxx; dwmw2@xxxxxxxxxxxxx > Subject: Re: [PATCH 5/6] mtd: spi-nor: Add s3an_post_sfdp_fixups() > > Hi, Naga, > > On 07/31/2019 03:31 PM, Naga Sureshkumar Relli wrote: > >> + if (nor->info->flags & SPI_S3AN) > >> + s3an_post_sfdp_fixups(nor); > >> } > >> > > Instead of checking the flags, why can't we call directly the nor_fixups? > > like Boris implementation nor->info->fixups->post_sfdp() > > https://patchwork.ozlabs.org/patch/1009291/ > > This check will vanish and nor->info->fixups->post_sfdp() will be called directly once I'll > respin the manufacturer driver part. post_sfdp() will set just flash parameters. Check Boris' > patch at https://patchwork.ozlabs.org/patch/1009295/ > > I'll try to respin the rest of Boris' patches sometime at the beginning of the next week. Ok, Thanks. Regards, Naga Sureshkumar Relli > > Cheers, > ta ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/