Le jeu. 27 juin 2019 à 18:40, Miquel Raynal
<miquel.raynal@xxxxxxxxxxx> a écrit :
Hi Paul,
Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote on Mon, 17 Jun 2019
14:16:59 +0200:
Hello,
Arnd Bergmann <arnd@xxxxxxxx> wrote on Mon, 17 Jun 2019 14:12:48
+0200:
> On Mon, Jun 17, 2019 at 1:24 PM Paul Cercueil
<paul@xxxxxxxxxxxxxxx> wrote:
>
> > I think there's a better way to fix it, only in Kconfig.
> >
> > * Add a bool symbol MTD_NAND_INGENIC_USE_HW_ECC
> > * Have the three ECC/BCH drivers select this symbol instead of
> > MTD_NAND_INGENIC_ECC
> > * Add the following to the MTD_NAND_JZ4780 config option:
> > "select MTD_NAND_INGENIC_ECC if MTD_NAND_INGENIC_USE_HW_ECC"
>
> I don't see much difference to my approach here, but if you want
> to submit that version with 'Reported-by: Arnd Bergmann
<arnd@xxxxxxxx>',
> please do so.
>
> Yet another option would be to use Makefile code to link both
> files into one module, and remove the EXPORT_SYMBOL statements:
>
> obj-$(CONFIG_MTD_NAND_JZ4780) += jz4780_nand.o
> jz4780_nand-y += ingenic_nand.o
> jz4780_nand-$(CONFIG_MTD_NAND_INGENIC_ECC) += ingenic_ecc.o
>
I personally have a preference for this one.
Would you mind sending the above change? I forgot about it but I would
like to queue it for the next release. Preferably the last version
Arnd
proposed.
It does change the module name from 'ingenic_nand' to 'jz4780_nand',
though.
That's not really ideal...
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
