Re: [PATCH v6 11/11] mtd: cfi_cmdset_0002: Disable write buffer functions if FORCE_WORD_WRITE is 1

[Vignesh Raghavendra <vigneshr@xxxxxx>]

On 26/05/19 9:09 PM, Tokunori Ikegami wrote:
> Some write buffer functions are not used when FORCE_WORD_WRITE is set to 1.
> So the compile warning messages are output if FORCE_WORD_WRITE is 1.
> To resolve this disable the write buffer functions if FORCE_WORD_WRITE is 1.
> 
> Signed-off-by: Tokunori Ikegami <ikegami.t@xxxxxxxxx>
> Cc: Fabio Bettoni <fbettoni@xxxxxxxxx>
> Co: Hauke Mehrtens <hauke@xxxxxxxxxx>
> Co: Koen Vandeputte <koen.vandeputte@xxxxxxxxxxxx>
> Cc: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>
> Cc: Joakim Tjernlund <Joakim.Tjernlund@xxxxxxxxxxxx>
> Cc: linux-mtd@xxxxxxxxxxxxxxxxxxx
> ---
> Changes since v5:
> - Add the patch.
> 
>  drivers/mtd/chips/cfi_cmdset_0002.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
> index 477bc3d65e68..2144221029e9 100755

Your patch seems to be changing permissions here:
warning: drivers/mtd/chips/cfi_cmdset_0002.c has type 100644, expected
100755

Please fix this up.

> --- a/drivers/mtd/chips/cfi_cmdset_0002.c
> +++ b/drivers/mtd/chips/cfi_cmdset_0002.c

[...]

> @@ -1836,6 +1840,7 @@ static int cfi_amdstd_write_words(struct mtd_info *mtd, loff_t to, size_t len,
>  	return 0;
>  }
>  > +#if !FORCE_WORD_WRITE
>  static int __xipram do_write_buffer_wait(struct map_info *map,
>  					 struct flchip *chip, unsigned long adr,
>  					 map_word datum)
> @@ -2064,6 +2069,7 @@ static int cfi_amdstd_write_buffers(struct mtd_info *mtd, loff_t to, size_t len,
>  
>  	return 0;
>  }
> +#endif /* !FORCE_WORD_WRITE */
>  

This should be part of the patch that introduces do_write_buffer_wait()

>  /*
>   * Wait for the flash chip to become ready to write data
> 

-- 
Regards
Vignesh

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/