Re: [PATCH 1/2] mtd/rawnand: ingenic-ecc: Make probe function __init_or_module

[Paul Cercueil <paul@xxxxxxxxxxxxxxx>]

I misunderstood what __init_or_module was for. Please ignore this 
patchset. Sorry for the noise.


Le ven. 7 juin 2019 à 18:01, Paul Cercueil <paul@xxxxxxxxxxxxxxx> a 
écrit :
> This allows the probe function to be dropped after the kernel finished
> its initialization, in the case where the driver was not compiled as a
> module.
>
> Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
> ---
>  drivers/mtd/nand/raw/ingenic/ingenic_ecc.c | 2 +-
>  drivers/mtd/nand/raw/ingenic/ingenic_ecc.h | 3 ++-
>  drivers/mtd/nand/raw/ingenic/jz4780_bch.c  | 2 +-
>  3 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/ingenic/ingenic_ecc.c 
> b/drivers/mtd/nand/raw/ingenic/ingenic_ecc.c
> index d3e085c5685a..74eff8fb5d32 100644
> --- a/drivers/mtd/nand/raw/ingenic/ingenic_ecc.c
> +++ b/drivers/mtd/nand/raw/ingenic/ingenic_ecc.c
> @@ -124,7 +124,7 @@ void ingenic_ecc_release(struct ingenic_ecc *ecc)
>  }
>  EXPORT_SYMBOL(ingenic_ecc_release);
>
> -int ingenic_ecc_probe(struct platform_device *pdev)
> +int __init_or_module ingenic_ecc_probe(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
>  	struct ingenic_ecc *ecc;
> diff --git a/drivers/mtd/nand/raw/ingenic/ingenic_ecc.h 
> b/drivers/mtd/nand/raw/ingenic/ingenic_ecc.h
> index 2cda439b5e11..535eb8f29df6 100644
> --- a/drivers/mtd/nand/raw/ingenic/ingenic_ecc.h
> +++ b/drivers/mtd/nand/raw/ingenic/ingenic_ecc.h
> @@ -4,6 +4,7 @@
>
>  #include <linux/compiler_types.h>
>  #include <linux/err.h>
> +#include <linux/module.h>
>  #include <linux/mutex.h>
>  #include <linux/types.h>
>  #include <uapi/asm-generic/errno-base.h>
> @@ -78,6 +79,6 @@ struct ingenic_ecc {
>  	struct mutex lock;
>  };
>
> -int ingenic_ecc_probe(struct platform_device *pdev);
> +int __init_or_module ingenic_ecc_probe(struct platform_device *pdev);
>
>  #endif /* __DRIVERS_MTD_NAND_INGENIC_ECC_INTERNAL_H__ */
> diff --git a/drivers/mtd/nand/raw/ingenic/jz4780_bch.c 
> b/drivers/mtd/nand/raw/ingenic/jz4780_bch.c
> index 079266a0d6cf..cc0656ac505d 100644
> --- a/drivers/mtd/nand/raw/ingenic/jz4780_bch.c
> +++ b/drivers/mtd/nand/raw/ingenic/jz4780_bch.c
> @@ -229,7 +229,7 @@ static int jz4780_correct(struct ingenic_ecc *bch,
>  	return ret;
>  }
>
> -static int jz4780_bch_probe(struct platform_device *pdev)
> +static int __init_or_module jz4780_bch_probe(struct platform_device 
> *pdev)
>  {
>  	struct ingenic_ecc *bch;
>  	int ret;
> --
> 2.21.0.593.g511ec345e18



______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/