Re: [PATCH v2] mkfs.ubifs: Add ZSTD compression

[Richard Weinberger <richard@xxxxxxxxxxxxx>]

Emil,

----- Ursprüngliche Mail -----
> The new mtd-utils with this patch doesn't compile on Ubuntu 18.04 LTS
> since it uses a slightly older version of zstd (1.3.3) that didn't
> have the macro ZSTD_CLEVEL_DEFAULT defined, which was introduced in
> version 1.3.5. Could you maybe consider adding the following lines in
> compr.c:
> 
> #ifndef ZSTD_CLEVEL_DEFAULT
> #define ZSTD_CLEVEL_DEFAULT 3
> #endif
> 
> or similar, which make it compile on slightly older distributions?

If I read the docs correctly, we can just pass 0 as compression level,
which will default to ZSTD_CLEVEL_DEFAULT.
https://github.com/facebook/zstd/pull/1174/commits/e34c000e44444b9f8bd62e5af0a355ee186eb21f

This should work on all zstd versions.

Thanks,
//richard

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/