Re: [PATCH v2] mtd: rawnand: initialize ntargets with maxchips

[Miquel Raynal <miquel.raynal@xxxxxxxxxxx>]

Hi Boris,

Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> wrote on Tue, 21 May
2019 11:40:22 +0200:

> On Tue, 21 May 2019 11:04:17 +0200
> Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:
> 
> > On Tue, 2019-05-21 at 08:43:35 UTC, Sascha Hauer wrote:  
> > > memorg->ntargets is initialized with '1'. It should be initialized with
> > > the maxchips argument from nand_scan() instead. Otherwise multi chip
> > > support errors out on the secondary chip selects when trying to call
> > > nand_reset() on them:
> > > 
> > > WARNING: CPU: 0 PID: 1 at drivers/mtd/nand/raw/internals.h:114
> > > nand_reset_op+0x194/0x1c4
> > > 
> > > With this memorg->ntargets is initialized with the maximum number of
> > > chip selects supported by the driver. After having detected the number
> > > of actually connected chips memory->ntargets is updated with that
> > > number.
> > > 
> > > Fixes: 32813e288414 ("mtd: rawnand: Get rid of chip->numchips")
> > > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> > > Reviewed-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>    
> > 
> > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.  
> 
> Are you sure it's mtd/next? I'd expect it to be queued in mtd/fixes not
> mtd/next.

Yes, I failed to checkout the right branch :)
I meant mtd/fixes, will move the patch.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/