Re: [RFC PATCH v3 1/1] mtd: rawnand: mtk: Re-license MTK NAND driver as Dual MIT/GPL

[Miquel Raynal <miquel.raynal@xxxxxxxxxxx>]

Hi xiaolei,

xiaolei li <xiaolei.li@xxxxxxxxxxxx> wrote on Mon, 6 May 2019 08:56:20
+0800:

> Hi Rafal,
> 
> On Sun, 2019-05-05 at 17:06 +0200, Rafał Miłecki wrote:
> > On 2019-05-05 11:12, xiaolei li wrote:  
> > > Up to now,
> > > Xiaolei Li <xiaolei.li@xxxxxxxxxxxx> (the author and major 
> > > contributor),
> > > Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@xxxxxxxxxx> (the author and
> > > major contributor),
> > > Ryder Lee <ryder.lee@xxxxxxxxxxxx> (developer),
> > > Rafał Miłecki <rafal@xxxxxxxxxx> (developer)
> > > sent ACK for this RFC patch.
> > > 
> > > May I ask if it is enough to accept this change? Or should I wait for
> > > other developer's response?  
> > 
> > I can't imagine re-licensing someone's work without a permission.  
> 
> I have no intention to offend other's contribution.
> That is why I sent this RFC patch to ask for ACKs from contributors.
> 
> > 
> > The best you can do is ignoring contributors that submitted changes that
> > aren't really copyrightable (something like fixing a comment typo, some
> > auto-generated diff-s).
> > 
> > I used following command to check mtk_nand.c file history:
> > # git log --follow drivers/mtd/nand/raw/mtk_nand.c | grep 
> > "Signed-off-by" | sort | uniq -c | sort -r -n
> >       19     Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> >       18     Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxx>
> >       15     Signed-off-by: Boris Brezillon 
> > <boris.brezillon@xxxxxxxxxxxxxxxxxx>
> >        6     Signed-off-by: Xiaolei Li <xiaolei.li@xxxxxxxxxxxx>
> >        3     Signed-off-by: RogerCC Lin <rogercc.lin@xxxxxxxxxxxx>
> >        2     Signed-off-by: Miquel Raynal 
> > <miquel.raynal@xxxxxxxxxxxxxxxxxx>
> >        1     Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> >        1     Signed-off-by: Ryder Lee <ryder.lee@xxxxxxxxxxxx>
> >        1     Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx>
> >        1     Signed-off-by: Peter Pan <peterpandong@xxxxxxxxxx>
> >        1     Signed-off-by: Masahiro Yamada 
> > <yamada.masahiro@xxxxxxxxxxxxx>
> >        1     Signed-off-by: Jorge Ramirez-Ortiz 
> > <jorge.ramirez-ortiz@xxxxxxxxxx>
> > 
> > Ideally you should still get acks from:
> > 
> > 1) Miquel
> > Contributor of 21 changes
> > 
> > 2) Boris
> > Contributor of 33 changes
> > 
> > 3) RogerCC
> > Contributor of 3 changes:
> > 98dea8d71931 ("mtd: nand: mtk: Support MT7622 NAND flash controller.")
> > b45ee5501ede ("mtd: nand: mtk: Support different MTK NAND flash 
> > controller IP")
> > 559e58e7ed2d ("mtd: nand: fix chances to create incomplete ECC data when 
> > writing")
> > 
> > 4) Wei
> > Contributor of 1 change:
> > 07f76443ef81 ("mtd: nand: mediatek: remove redundant dev_err call in 
> > mtk_nfc_probe()")
> > 
> > 5) Peter
> > Contributor of 1 change:
> > d4092d76a4a4 ("mtd: nand: Rename nand.h into rawnand.h")
> > 
> > 6) Masahiro
> > Contributor of 1 change:
> > f0dbe4aa35e7 ("mtd: nand: mediatek: return error code of 
> > nand_scan_ident/tail() on error")
> > 
> > I guess we could accept your patch without acks from Wei, Peter and 
> > Masahiro.
> > 
> > You definitely need an approval from Miquel, Boris and RogerCC.

Acked-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>

Let's wait for RogerCC and Boris acks. Thanks Rafał for the details.

> > 
> > It doesn't seem you took this re-licensing task too seriously.
> > 
> > Please pay more attention to this licensing problem, you can start with 
> > doing
> > a similar research for mtk_ecc.c and mtk_ecc.h.  
> 
> Thanks for your ACK and good suggestion. It is really helpful for me.
> 
> Thanks,
> Xiaolei
> 


Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/