Re: i.MX28 nand driver broken in Linux 4.18

[Wolfgang Grandegger <wg@xxxxxxxxxxxxxx>]

Hello Miquel,

Am 06.03.19 um 14:59 schrieb Miquel Raynal:
> Hi Wolfgang,
> 
> Wolfgang Grandegger <wg@xxxxxxxxxxxxxx> wrote on Tue, 5 Mar 2019
> 15:52:52 +0100:
> 
>> Hello,
>>
>> I will bisect the problem next week when I have access to the
>> hardware... more soon...
>>
> 
> Great, thanks.

Here is the result of git bisection:

wolf@bernex:~/git/linux$ git bisect good
76e1a0086a0c3276b384f77905345e0fcc886fdd is the first bad commit
commit 76e1a0086a0c3276b384f77905345e0fcc886fdd
Author: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
Date:   Fri Mar 2 15:38:39 2018 +0100

    mtd: rawnand: gpmi: support ->setup_data_interface()
    
    Until now the GPMI driver had its own timings logic while the core
    already handles that and request the NAND controller drivers to support
    the ->setup_data_interface() hook. Implement that hook by reusing the
    already existing function. No real glue is necessary between core timing
    delays and GPMI registers because the driver already translates the
    ONFI timing modes into register values.
    
    Make use of the core's tREA, tRLOH and tRHOH values that allow computing
    more precise timings for mode [0-3] and get significantly better values
    (+20% with an i.MX6 Sabre Auto board). Otherwise use the existing logic.
    
    Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
    Tested-by: Han Xu <han.xu@xxxxxxx>
    Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxx>

:040000 040000 938baf080db67ef7af38509421e11704da11baca 7f792706ecdd81977373dc8f44cccf28280f12ba M	drivers

At the end, I have added the full "git biscect log".

> 
> Please don't forget to keep MTD maintainers in Cc: to speed up the
> discussion.

OK.

wolf@bernex:~/git/linux$ git bisect log
# bad: [94710cac0ef4ee177a63b5227664b38c95bbf703] Linux 4.18
# good: [bebc6082da0a9f5d47a1ea2edc099bf671058bd4] Linux 4.14
git bisect start '94710cac0ef4ee177a63b5227664b38c95bbf703' 'bebc6082da0a9f5d47a1ea2edc099bf671058bd4'
# good: [053533fc7577ddbe14b2a7c4a8fc70ce3fbb3547] selftests: rtnetlink: remove testns on test fail
git bisect good 053533fc7577ddbe14b2a7c4a8fc70ce3fbb3547
# bad: [a1a3a0624e6cd0e2c46a7400800a5e687521a504] perf kcore_copy: Copy x86 PTI entry trampoline sections
git bisect bad a1a3a0624e6cd0e2c46a7400800a5e687521a504
# good: [9abf8acea297b4c65f5fa3206e2b8e468e730e84] Merge tag 'tty-4.17-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty
git bisect good 9abf8acea297b4c65f5fa3206e2b8e468e730e84
# bad: [299f89d53e61c0b17479cc7d6f3b5382d5e83f28] Merge tag 'leaks-4.17-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tobin/leaks
git bisect bad 299f89d53e61c0b17479cc7d6f3b5382d5e83f28
# good: [274c0e74e508c939a4ae5ef3890fddb4af537b76] Merge tag 'f2fs-for-4.17' of git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs
git bisect good 274c0e74e508c939a4ae5ef3890fddb4af537b76
# good: [b240b419db5d624ce7a5a397d6f62a1a686009ec] Merge tag 'armsoc-dt' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc
git bisect good b240b419db5d624ce7a5a397d6f62a1a686009ec
# bad: [3b54765cca23152ec0cc254b75c877c10f6e2870] Merge branch 'akpm' (patches from Andrew)
git bisect bad 3b54765cca23152ec0cc254b75c877c10f6e2870
# good: [38c23685b273cfb4ccf31a199feccce3bdcb5d83] Merge tag 'armsoc-drivers' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc
git bisect good 38c23685b273cfb4ccf31a199feccce3bdcb5d83
# bad: [3fd14cdcc05a682b03743683ce3a726898b20555] Merge tag 'mtd/for-4.17' of git://git.infradead.org/linux-mtd
git bisect bad 3fd14cdcc05a682b03743683ce3a726898b20555
# bad: [097ccca726ffedb277c104aba45c59d075969e51] mtd: nand: Fix some function description mismatches in core.c
git bisect bad 097ccca726ffedb277c104aba45c59d075969e51
# good: [ecc40b8df59a13dc1c1abd8abe4361e4160d29ea] mtd: rawnand: vf610_nfc: remove old hooks
git bisect good ecc40b8df59a13dc1c1abd8abe4361e4160d29ea
# good: [480139d9229e3be0530bc548da208b5f49b1ab90] mtd: rawnand: get rid of the JEDEC parameter page in nand_chip
git bisect good 480139d9229e3be0530bc548da208b5f49b1ab90
# bad: [4acc3046ed5c1641874b89fe66ef8707d81ff80e] mtd: rawnand: davinci: fix probe function error path
git bisect bad 4acc3046ed5c1641874b89fe66ef8707d81ff80e
# bad: [961ba15c48dd465fdbef1b9379bd8031c374d62e] mtd: rawnand: marvell: Fix clock resource by adding a register clock
git bisect bad 961ba15c48dd465fdbef1b9379bd8031c374d62e
# bad: [76e1a0086a0c3276b384f77905345e0fcc886fdd] mtd: rawnand: gpmi: support ->setup_data_interface()
git bisect bad 76e1a0086a0c3276b384f77905345e0fcc886fdd
# good: [bd0b64340c2d66c0fe1aa99b0b23159d7e0c21f2] mtd: rawnand: get rid of the ONFI parameter page in nand_chip
git bisect good bd0b64340c2d66c0fe1aa99b0b23159d7e0c21f2
# first bad commit: [76e1a0086a0c3276b384f77905345e0fcc886fdd] mtd: rawnand: gpmi: support ->setup_data_interface()

Hope it helps to locate the problem.

Wolfgang

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/