Re: [PATCH] mtd: lpddr_cmds: Mark expected switch fall-through

["Gustavo A. R. Silva" <gustavo@xxxxxxxxxxxxxx>]

On 2/13/19 8:05 AM, Boris Brezillon wrote:
> On Tue, 12 Feb 2019 09:31:31 -0600
> "Gustavo A. R. Silva" <gustavo@xxxxxxxxxxxxxx> wrote:
> 
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/mtd/lpddr/lpddr_cmds.c: In function ‘chip_ready’:
>> drivers/mtd/lpddr/lpddr_cmds.c:319:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>    if (mode == FL_READY && chip->oldstate == FL_READY)
>>       ^
>> drivers/mtd/lpddr/lpddr_cmds.c:322:2: note: here
>>   default:
>>   ^~~~~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
> 
> You sent me that one twice, is that expected? Is this a new version,
> and in that case, what has changed?
> 

Oh, it wasn't intentional.  Both are exactly the same patch.

Sorry about that.

--
Gustavo


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/