Hi, This one looks pretty good. You'll have to start the patch's subject with "mtd: spi-nor:" instead of just "spi-nor". When in doubt, run git log --oneline on the file that you are modifying and see how previous patches are prefixing the subject. On 08/07/2018 10:40 PM, Palmer Dabbelt wrote: > From: "Wesley W. Terpstra" <wesley@xxxxxxxxxx> > > This is used of the HiFive Unleashed development board, and follows the > pattern of similar ISSI devices already listed. > Please add a comment and let us know how you tested the flash, it's always comfortable to see that new support was actually tested. > Signed-off-by: Wesley W. Terpstra <wesley@xxxxxxxxxx> > Signed-off-by: Palmer Dabbelt <palmer@xxxxxxxxxx> > --- > drivers/mtd/spi-nor/spi-nor.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index aab93463a5e7..f10017b4543d 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -1072,6 +1072,8 @@ static const struct flash_info spi_nor_ids[] = { > SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, > { "is25wp128", INFO(0x9d7018, 0, 64 * 1024, 256, > SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, > + { "is25wp256", INFO(0x9d7019, 0, 64 * 1024, 512, > + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, You missed the SPI_NOR_4B_OPCODES flag. The flash has 4B opcodes, let's use them. Cheers, ta ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/