Re: [PATCH v4 2/3] mtd: spi-nor: Add a post BFPT parsing fixup hook

[Boris Brezillon <boris.brezillon@xxxxxxxxxxx>]

On Wed, 5 Dec 2018 16:35:15 +0000
<Tudor.Ambarus@xxxxxxxxxxxxx> wrote:

> On 11/29/2018 04:41 PM, Boris Brezillon wrote:
> > +struct spi_nor_fixups {
> > +	int (*post_bfpt)(struct spi_nor *nor,
> > +			 const struct sfdp_parameter_header *bfpt_header,
> > +			 const struct sfdp_bfpt *bfpt,
> > +			 struct spi_nor_flash_parameter *params);
> > +};  
> 
> I like the idea. The code looks good. What I noticed is that the sfdp logic is
> now split in different sections of spi-nor file. In order to avoid the burden of
> moving the sfdp code inside spi-nor, you can have these 3 forward declarations
> and do the sfdp move later on, in a separate file.

I tried that, but then I need some of those definitions in my
mx25l25635_post_bfpt_fixups(), so I'm screwed anyway. Also, it's not
really a matter to have SFDP split in 2 sections as we're going to move
all the code in a separate file soon ;-).

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/