Re: [PATCH v4 2/3] mtd: spi-nor: Add a post BFPT parsing fixup hook

[<Tudor.Ambarus@xxxxxxxxxxxxx>]

On 11/29/2018 04:41 PM, Boris Brezillon wrote:
> +struct spi_nor_fixups {
> +	int (*post_bfpt)(struct spi_nor *nor,
> +			 const struct sfdp_parameter_header *bfpt_header,
> +			 const struct sfdp_bfpt *bfpt,
> +			 struct spi_nor_flash_parameter *params);
> +};

I like the idea. The code looks good. What I noticed is that the sfdp logic is
now split in different sections of spi-nor file. In order to avoid the burden of
moving the sfdp code inside spi-nor, you can have these 3 forward declarations
and do the sfdp move later on, in a separate file.

ta
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/