Re: [PATCH v4 8/8] mtd: maps: gpio-addr-flash: Add support for device-tree devices

[Boris Brezillon <boris.brezillon@xxxxxxxxxxx>]

On Mon,  1 Oct 2018 14:43:51 +0200
Ricardo Ribalda Delgado <ricardo.ribalda@xxxxxxxxx> wrote:

> +static int gpio_flash_probe_gpios(struct platform_device *pdev,
> +				  struct async_state *state)
> +{
> +	struct physmap_flash_data *pdata;
> +	struct device_node *dn;
> +	struct resource *gpios = NULL;
> +	int i;
> +
> +	dn = pdev->dev.of_node;
> +	if (dn) {
> +		state->gpios = devm_gpiod_get_array(&pdev->dev, NULL,
> +						    GPIOD_OUT_LOW);

Did you consider using gpiod_set_array_value() to update the gpio vals
instead of having your own update loop (the for loop in the
gf_set_gpios() func)?

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/