Hi Boris, Boris Brezillon <boris.brezillon at bootlin.com> wrote on Wed, 18 Jul 2018 23:58:45 +0200: > On Wed, 18 Jul 2018 23:50:55 +0200 > Miquel Raynal <miquel.raynal at bootlin.com> wrote: > > > > /** > > - * struct nand_hw_control - Control structure for hardware controller (e.g ECC generator) shared among independent devices > > + * struct nand_controller - Control structure for hardware controller > > Hm, the description is weird. How about "NAND controller object" or > "Structure used to describe a NAND controller" > > Other than this detail, it looks all good to me. That's right I don't like it neither. I just removed the "e.g ECC generator" which was wrong but it deserves a better definition. I'll stick to "Structure used to describe a NAND controller" which is clear enough for me. I'll fix when applying. Thanks, Miqu?l