On Wed, 18 Jul 2018 23:50:55 +0200 Miquel Raynal <miquel.raynal at bootlin.com> wrote: > > /** > - * struct nand_hw_control - Control structure for hardware controller (e.g ECC generator) shared among independent devices > + * struct nand_controller - Control structure for hardware controller Hm, the description is weird. How about "NAND controller object" or "Structure used to describe a NAND controller" Other than this detail, it looks all good to me. > + * shared among independent devices > * @lock: protection lock > * @active: the mtd device which holds the controller currently > * @wq: wait queue to sleep on if a NAND operation is in > * progress used instead of the per chip wait queue > * when a hw controller is available. > */ > -struct nand_hw_control { > +struct nand_controller { > spinlock_t lock; > struct nand_chip *active; > wait_queue_head_t wq; > };