Hi Chunhui, kernel test robot noticed the following build warnings: [auto build test WARNING on mcgrof/modules-next] [also build test WARNING on linus/master v6.11-rc6 next-20240906] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Chunhui-Li/module-abort-module-loading-when-sysfs-setup-suffer-errors/20240907-000002 base: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git modules-next patch link: https://lore.kernel.org/r/20240906115748.5367-2-chunhui.li%40mediatek.com patch subject: [PATCH v3 1/1] module: abort module loading when sysfs setup suffer errors config: openrisc-defconfig (https://download.01.org/0day-ci/archive/20240907/202409072018.qfEzZbO7-lkp@xxxxxxxxx/config) compiler: or1k-linux-gcc (GCC) 14.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240907/202409072018.qfEzZbO7-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202409072018.qfEzZbO7-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): kernel/module/sysfs.c: In function 'add_sect_attrs': >> kernel/module/sysfs.c:232:67: warning: no return statement in function returning non-void [-Wreturn-type] 232 | static inline int add_sect_attrs(struct module *mod, const struct load_info *info) { } | ^~~~~~~~~ kernel/module/sysfs.c: In function 'add_notes_attrs': kernel/module/sysfs.c:234:68: warning: no return statement in function returning non-void [-Wreturn-type] 234 | static inline int add_notes_attrs(struct module *mod, const struct load_info *info) { } | ^~~~~~~~~ vim +232 kernel/module/sysfs.c 230 231 #else /* !CONFIG_KALLSYMS */ > 232 static inline int add_sect_attrs(struct module *mod, const struct load_info *info) { } 233 static inline void remove_sect_attrs(struct module *mod) { } 234 static inline int add_notes_attrs(struct module *mod, const struct load_info *info) { } 235 static inline void remove_notes_attrs(struct module *mod) { } 236 #endif /* CONFIG_KALLSYMS */ 237 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki