On Fri, Sep 06, 2024 at 07:57:48PM +0800, Chunhui Li wrote: > When insmod a kernel module, if fails in add_notes_attrs or > add_sysfs_attrs such as memory allocation fail, mod_sysfs_setup > will still return success, but we can't access user interface > on android device. > > Patch for make mod_sysfs_setup can check the error of > add_notes_attrs and add_sysfs_attrs > > Acked-by: Luis Chamberlain <mcgrof@xxxxxxxxxx> > Reviewed-by: Petr Pavlu <petr.pavlu@xxxxxxxx> > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Closes: https://lore.kernel.org/oe-kbuild-all/202409010016.3XIFSmRA-lkp@xxxxxxxxx/ > Signed-off-by: Xion Wang <xion.wang@xxxxxxxxxxxx> > Signed-off-by: Chunhui Li <chunhui.li@xxxxxxxxxxxx> Please add a Fixes: tag. Luis