On 8/29/24 00:53, Sami Tolvanen wrote: > On Wed, Aug 28, 2024 at 04:04:09PM +0900, Masahiro Yamada wrote: >> On Fri, Aug 16, 2024 at 2:39 AM Sami Tolvanen <samitolvanen@xxxxxxxxxx> wrote: >>> - Added a --symtypes flag for generating a genksyms-style >>> symtypes output based on Petr's feedback, and refactored >>> symbol version calculations to be based on symtypes instead >>> of raw --dump-dies output. >> >> >> >> I do not know if this is worthwhile. > > Greg, Petr, do you want to comment on the usefulness of the symtypes > output? I was under the impression it was a useful tool for figuring > out exactly what caused the versions to change? Right, the symtypes data is useful if distributions wish to maintain stable kABI for their kernels. The data can be compressed/consolidated and stored together with the source code for the distribution kernel, serving as a reference kABI. Later, when the kernel is updated and CRCs of some symbols change, the reference can be compared with the new symtypes data to understand what has actually changed. The previous discussion was under v1 of the series: https://lore.kernel.org/linux-modules/0b2697fd-7ab4-469f-83a6-ec9ebc701ba0@xxxxxxxx/t/#u -- Cheers, Petr