Hello, >>Seems like this commit has regressed make distcheck on my end. Namely >>I'm running the following commands: >> >>git clone ... >>cd kmod >>git clean -fxd >>./autogen.sh c >>make distcheck >> >>Result in: >> >>... >>make[5]: *** No rule to make target '.../kmod-32/_build/sub/testsuite/module-playground/mod-weakdep.o', needed by '.../kmod-32/_build/sub/testsuite/module-playground/mod-weakdep.mod'. Stop. >>make[4]: *** [Makefile:1903: .../kmod-32/_build/sub/testsuite/module-playground] Error 2 > >I added a fix in >https://lore.kernel.org/linux-modules/20240709044758.67725-1-lucas.de.marchi@xxxxxxxxx/T/#t > >and also sketched the new CI hooks using github. > >>Can you reproduce it on your end? Sorry Emil, I only tested with 'make check' and I didn't try 'make distcheck' (really I didn't know it). Yes, it was failing for me too, and I have verified that with the solution from Lucas ([PATCH 2/3] build: Add mod-weakdep.c to EXTRA_DIST) is working. Thanks Lucas for fixing it. >> >> >>- Is this work related to the weak-modules used in RHEL/Fedora [1]? >> Alternatively, would the RedHat team consider having the weak-modules >> solution in upstream kmod? >> >>... assuming Lucas is OK with the idea. I'm approaching with with my >>dkms co-maintainer hat on, where the fewer "if distro == X" logic we >>have the better. > >I was not familiar with that weak-modules and will wait for Jose to >clarify. weak modules concept is very different from weak dependencies and not related. Let me try to explain: weak modules is about keeping KABI compatibility between kernels with the same version, in order to reuse modules (internal or external ones), so it is mainly for RHEL and the update process. For Fedora, that is the upstream distro, and with no guarantee for KABI, is not necessary. weak dependencies is to be used by upstream (and everywhere) to allow user applications to be aware of internal dependencies that are not declared as softdep because they are dynamically loaded. dracut has approved this feature from yesterday and I am waiting to have the kernel declaration in linux master branch to apply some weak dependencies (i.e. lan78xx). Best regards José Ignacio
