On Mon, Oct 02, 2023 at 09:57:59AM -0700, Kees Cook wrote: > On Mon, Oct 02, 2023 at 03:48:51PM +0300, Andy Shevchenko wrote: > > A couple of patches are for get the string ops, used in the module, > > slightly harden. On top a few cleanups. > > > > Since the main part is rather hardening, I think the Kees' tree is > > the best fit for the series, but I'm open for another option(s). > > > > Changelog v2: > > - dropped the s*printf() --> sysfs_emit() conversion as it revealed > > an issue, i.e. reuse getters with non-page-aligned pointer, which > > would be addressed separately > > - added cover letter and clarified the possible route for the series > > (Luis) > > > > Andy Shevchenko (5): > > params: Introduce the param_unknown_fn type > > params: Do not go over the limit when getting the string length > > params: Use size_add() for kmalloc() > > params: Sort headers > > params: Fix multi-line comment style > > Seems like a nice bit of clean-up. > > Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx> Reviewed-by: Luis Chamberlain <mcgrof@xxxxxxxxxx> Luis