On Tue, Feb 10, 2015 at 8:44 AM, Tobias Stöckmann <tobias@xxxxxxxxxxxxxx> wrote: > Hi again, > >> On February 10, 2015 at 11:31 AM Lucas De Marchi <lucas.de.marchi@xxxxxxxxx> >> wrote: >> sizeof(uint64_t) == sizeof(unsigned long) both on 32 and 64 bits... no >> need to use long long. > > long on 32 bit systems (at least my i686) is 32 bit -- granted, the C standard > doesn't explicitly require that. Yet I didn't encounter a 32 bit Linux with 64 > bit long, please correct me if I'm wrong and there are such systems out there. > long long would be 64 bit on both. oohh... I blame the lack of coffee early in the morning for my stupid comment. Indeed, you are right. > >> are you going to submit the patch or you're waiting on me? > > I have no commit access, so I am waiting for you. :) > As stated before, please use the long long variant. well, you could submit to the mailing list a patch series :-) Anyway, I applied this patch, added addu64_overflow() abstracting if the compiler has the builtin and converted your patch to use this new function. Let me know of the other problems you talked about. thanks -- Lucas De Marchi -- To unsubscribe from this list: send the line "unsubscribe linux-modules" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
