Hi again, > On February 10, 2015 at 11:31 AM Lucas De Marchi <lucas.de.marchi@xxxxxxxxx> > wrote: > sizeof(uint64_t) == sizeof(unsigned long) both on 32 and 64 bits... no > need to use long long. long on 32 bit systems (at least my i686) is 32 bit -- granted, the C standard doesn't explicitly require that. Yet I didn't encounter a 32 bit Linux with 64 bit long, please correct me if I'm wrong and there are such systems out there. long long would be 64 bit on both. > are you going to submit the patch or you're waiting on me? I have no commit access, so I am waiting for you. :) As stated before, please use the long long variant. > If this is pointed out by any static analysis tool, feel free to add that > in the commit message. It's a review by hand. But speaking of analysis, I wonder what afl could come up with... Tobias -- To unsubscribe from this list: send the line "unsubscribe linux-modules" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
