Lucas De Marchi <lucas.de.marchi@xxxxxxxxx> schreef: >On Tue, Sep 30, 2014 at 4:41 AM, Thomas De Schampheleire ><patrickdepinguin@xxxxxxxxx> wrote: >> From: Robert Yang <liezhi.yang@xxxxxxxxxxxxx> >> >> O_CLOEXEC is introduced from Linux 2.6.23, so old kernel doesn't have >> it, we need check before use. > >Humn... Do we really want to support kernels older than 2.6.23? > >Adding a workaround like this IMO will just hide bugs because we rely >on O_CLOEXEC semantics. Doing nothing is not really what we want. >Maybe if ancient downstream distros want the workaround they can >define O_CLOEXEC by themselves during build... passing it in CFLAGS >should work > This is the same type of distro for which the implementation of be32toh was needed: RHEL5. Ancient, yes, but still supported and used in corporate environments, also to build modern systems, for example using Buildroot or Openembedded. The patch comes from openembedded and is about to be integrated in Buildroot too, but it's far more advantageous to have such changes integrated upstream. Thanks, Thomas -- To unsubscribe from this list: send the line "unsubscribe linux-modules" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
