On Tue, Sep 30, 2014 at 4:41 AM, Thomas De Schampheleire <patrickdepinguin@xxxxxxxxx> wrote: > From: Robert Yang <liezhi.yang@xxxxxxxxxxxxx> > > O_CLOEXEC is introduced from Linux 2.6.23, so old kernel doesn't have > it, we need check before use. Humn... Do we really want to support kernels older than 2.6.23? Adding a workaround like this IMO will just hide bugs because we rely on O_CLOEXEC semantics. Doing nothing is not really what we want. Maybe if ancient downstream distros want the workaround they can define O_CLOEXEC by themselves during build... passing it in CFLAGS should work -- Lucas De Marchi -- To unsubscribe from this list: send the line "unsubscribe linux-modules" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html