On Tue, Jul 31, 2012 at 1:02 AM, Colin Walters <walters@xxxxxxxxxx> wrote: > On Mon, 2012-07-30 at 20:32 -0300, Lucas De Marchi wrote: > >> ok, I'm not a fan of this, but I'm going to accept it. > > Note I've landed similar patches in various other components: > http://cgit.freedesktop.org/systemd/systemd/commit/?id=3840d318011a20960119ff8dff1f67825b2ca0f1 > (Well, Kay wrote that one for me) Yeah... I checked systemd's configure.ac before really saying I was going to accept it ;-). Although I think the way it's in systemd (like your previous patch) is not the best way. > >> 1) Change it to be similar to the entry for "--disable-tools", so >> there's no need to the "if test .." you added >> 2) Add an entry below "doc" to say if manpages are enabled or disabled. > > Done; see attached. You forgot the entry below "doc", in the end of the file. Anyway it was simple enough so I applied another patch on top. > >> And please don't forget to CC linux-modules@xxxxxxxxxxxxxxx > > Ok, but hopefully I don't have to be subscribed since I'm already on > waaaay too many mailing lists... You don't. It follows lkml style. thanks, Lucas De Marchi -- To unsubscribe from this list: send the line "unsubscribe linux-modules" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
