Re: [PATCH] build-sys: Add --disable-manpages option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2012-07-30 at 20:32 -0300, Lucas De Marchi wrote:

> ok, I'm not a fan of this, but I'm going to accept it. 

Note I've landed similar patches in various other components:
http://cgit.freedesktop.org/systemd/systemd/commit/?id=3840d318011a20960119ff8dff1f67825b2ca0f1
(Well, Kay wrote that one for me)

> 1) Change it to be similar to the entry for "--disable-tools", so
> there's no need to the "if test .." you added
> 2) Add an entry below "doc" to say if manpages are enabled or disabled.

Done; see attached.

> And please don't forget to CC linux-modules@xxxxxxxxxxxxxxx

Ok, but hopefully I don't have to be subscribed since I'm already on
waaaay too many mailing lists...

>From c5780f0d17042437e0af137640645442859cf5e3 Mon Sep 17 00:00:00 2001
From: Colin Walters <walters@xxxxxxxxxx>
Date: Mon, 30 Jul 2012 12:27:10 -0400
Subject: [PATCH] build-sys: Add --disable-manpages option

1) Embedded systems often don't want man pages on the
   target; rather than pointlessly building them, then ignoring
   the result, allow just not building them at all
2) When bootstrapping an operating systems, documentation is the
   source of many cyclical dependencies, and allowing it to
   be explicitly disabled is useful for earlier build passes.
---
 Makefile.am  | 6 +++++-
 configure.ac | 5 +++++
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am
index 26f32cd..bc95922 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,4 +1,8 @@
-SUBDIRS = . libkmod/docs man
+SUBDIRS = . libkmod/docs
+
+if BUILD_MANPAGES
+SUBDIRS += man
+endif
 
 DISTCLEAN_LOCAL_HOOKS =
 EXTRA_DIST =
diff --git a/configure.ac b/configure.ac
index 8a4a063..da8cd57 100644
--- a/configure.ac
+++ b/configure.ac
@@ -89,6 +89,11 @@ AC_ARG_ENABLE([tools],
 	[], enable_tools=yes)
 AM_CONDITIONAL([BUILD_TOOLS], [test "x$enable_tools" = "xyes"])
 
+AC_ARG_ENABLE([manpages],
+        AS_HELP_STRING([--disable-manpages], [disable manpages @<:@default=enabled@:>@]),
+	[], enable_manpages=yes)
+AM_CONDITIONAL([BUILD_MANPAGES], [test "x$enable_manpages" = "xyes"])
+
 AC_ARG_ENABLE([logging],
 	AS_HELP_STRING([--disable-logging], [disable system logging @<:@default=enabled@:>@]),
 	[], enable_logging=yes)
-- 
1.7.11.2


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux