Re: [Mit-devel] [PATCH] generate-modprobe.conf: handle duplicate aliases

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday 16 October 2009 04:54:50 Alan Jenkins wrote:
> On 10/16/09, Mike Frysinger wrote:
> > On Sunday 08 February 2009 19:02:25 Mike Frysinger wrote:
> >> Keep from blowing up when people have duplicate aliases in their files.
> >> The grep ends up including new lines and with certain formed comments,
> >> hits an infinite loop.
> >>
> >> For example, the following inputs illustrates the problem:
> >> ----------------------------------------------
> >> alias char-major-195 NVdriver
> >> alias /dev/nvidiactl char-major-195
> >> alias char-major-195 nvidia
> >> alias /dev/nvidiactl char-major-195
> >> ----------------------------------------------
> >> alias a b
> >> alias b a
> >> ----------------------------------------------
> >
> > no feedback on this change ?
> 
> I don't understand the changelog - I don't see the loop in the first
> example, and I don't understand why it also depends on having "certain
> formed comments".

hmm, the required comments were lost for some reason (maybe my fault?)

> That said, I've no objection to applying it as-is.  Everyone else has
> long forgotten about this script, so I don't expect to understand it,
> and I'm sure any hypothetical bug reports would be (re)directed to the
> person who last touched it :).

why dont we just drop it already instead ?  then there is no need for patching
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux