On Sun, 2009-10-18 at 10:38 +0100, Alan Jenkins wrote: > On 10/18/09, Philipp Weis <pweis@xxxxxxxxx> wrote: > > On 2009-09-30 16:49, Alan Jenkins <sourcejedi.lkml@xxxxxxxxxxxxxx> wrote: > >> The manpage does say modprobe -q "will simply ignore any bogus names", > >> implying that modprobe should return success in this case. But > >> test-modprobe/19quiet.sh has always required "modprobe -q crap" to > >> return failure. > >> > >> So this is intentional at some level, we've always done it this way in > >> the past, and we need to consider the risk of breaking scripts which > >> expect the current behaviour. > >> > >> The binfmt-support initscript seems a bad example to me. It does this > >> > >> # comments added by me > >> > >> set -e # abort if any command fails > >> ... > >> modprobe -q binfmt_misc # this will cause an abort if > >> binfmt_misc.ko doesn't exist... > >> mount -t binfmt_misc ... # but so will this > >> > >> It's only a problem if binfmt_misc is built into the kernel. However, > >> this will be solved by the modules.builtin work. > >> > >> So I think we would need a better justification to change this. > > > > Ok, but then the manpage should be fixed. How about the attached > > patch? > > > > Philipp > > Looks good to me. Agreed. Jon. -- To unsubscribe from this list: send the line "unsubscribe linux-modules" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
