Ping.
Thanks,
Avri
> > sparse would always be invoked, since `ifdef C` is always true afet `C ?= xx`.
> > Instead, use ifeq to check if C is 0 or 1.
> >
> > Check that `make C=0` does not invoke sprase.
> >
> > Fixes f884bfe684f ("mmc-utils: Make functions static for local scope
> > enforcement")
> Nit sha1 should be 12 characters.
>
> >
> > Signed-off-by: Gwendal Grignou <gwendal@xxxxxxxxxxxx>
> Reviewed-by: Avri Altman <avri.altman@xxxxxxx>
>
> > ---
> > Changes from v1:
> > - added signature
> > - add test line to enphasize it is not a revert.
> >
> > Makefile | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Makefile b/Makefile
> > index 06ae0f7..c0284bb 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -27,14 +27,14 @@ progs = mmc
> >
> > # make C=1 to enable sparse - default C ?= 1 -ifdef C
> > +ifeq "$(C)" "1"
> > check = sparse $(CHECKFLAGS) $(AM_CFLAGS) endif
> >
> > all: $(progs)
> >
> > .c.o:
> > -ifdef C
> > +ifeq "$(C)" "1"
> > $(check) $<
> > endif
> > $(CC) $(CPPFLAGS) $(CFLAGS) $(DEPFLAGS) -c $< -o $@
> > --
> > 2.48.1.362.g079036d154-goog
>
