Hi Wolfram, Thanks for the feedback. > -----Original Message----- > From: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > Sent: 28 February 2025 09:36 > Subject: Re: [PATCH v3 2/8] mmc: renesas_sdhi: Arrange local variables in reverse xmas tree order > > > > struct tmio_mmc_data *mmd = pdev->dev.platform_data; > > - struct tmio_mmc_data *mmc_data; > > struct renesas_sdhi_dma *dma_priv; > > + struct tmio_mmc_data *mmc_data; > > I'd prefer to have the same types close to each other. OK, will drop this patch. Cheers, Biju