Hi Sumit, On Tue, Aug 13, 2024 at 1:40 PM Sumit Garg <sumit.garg@xxxxxxxxxx> wrote: > > Hi Jens, > > On Mon, 12 Aug 2024 at 19:01, Jens Wiklander <jens.wiklander@xxxxxxxxxx> wrote: > > > > Add tee_device_set_dev_groups() to TEE drivers to supply driver specific > > attribute groups. The class specific attributes are from now on added > > via the tee_class, which currently only consist of implementation_id. > > > > Signed-off-by: Jens Wiklander <jens.wiklander@xxxxxxxxxx> > > --- > > drivers/misc/rpmb-core.c | 155 +++++++++++++++++++-------------------- > > These changes don't seem to belong to this patch but rather patch #1. > > > drivers/tee/tee_core.c | 19 +++-- > > > include/linux/rpmb.h | 53 +++++-------- > > Ditto here. Ouch, thanks for noticing this. I'll fix it in the next version. Cheers, Jens