Re: breaking commit: mmc: moxart-mmc: Use sg_miter for PIO

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Apr 20, 2024 at 10:38 PM Sergei Antonov <saproj@xxxxxxxxx> wrote:

> Hello, Linus!
> I see that commit 3ee0e7c3e67cab83ffbbe7707b43df8d41c9fe47 (mmc:
> moxart-mmc: Use sg_miter for PIO) leads to "BUG: scheduling while
> atomic".
>
> Can you suggest a way to rework the code and fix this problem? I can
> probably make a patch then. The waiting part of this driver needs
> improvement anyway. It calls
> wait_for_completion_interruptible_timeout() without checking its
> return value.

I have no idea why this happens, so if it solves the problem we should
revert the patch, because I do not think it is used on HIGHMEM
systems so it doesn't really need to use the sg_miter() iterator.

Yours,
Linus Walleij





[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux