On Tue, Feb 13, 2024 at 12:03 AM Tony Lindgren <tony@xxxxxxxxxxx> wrote: > > * Adam Ford <aford173@xxxxxxxxx> [240212 13:24]: > > On Mon, Feb 12, 2024 at 1:28 AM Tony Lindgren <tony@xxxxxxxxxxx> wrote: > > > > > > * Adam Ford <aford173@xxxxxxxxx> [240208 12:57]: > > > > I was testing the newer MMC driver on an AM3517 a few months ago, and > > > > I noticed that SD cards were returning weird or empty data after some > > > > indeterminate amount of time. If I read the IOS file immediately > > > > after boot, it worked. If I forced some sort of file IO, it might > > > > work, but after it went idle, it appeared to have strange data. I > > > > don't think this bug is limited to one platform. > > > > > > OK interesting. So the zero values for ios are expected when the card > > > is idle. What do you mean by weird values when idle? > > > > I meant zero-values when I said weird. It's weird to me, because > > other platforms don't return zero. > > If tha's normal, I'll likely submit an update to omap3.dtsi to migrate > > the MMC driver to the newer one. > > I'd been meaning to do that for a while, but this threw me off, then i > > forgot about it until I saw this thread. > > Yes I'd like to enable sdhci-omap and deprecate omap_hsmmc too. > > Assuming no issues and if the hs200 issue is a separate issue, maybe > post the patches and then let's get some Tested-by for them before we > put them into Linux next. I just sent a patch against omap3.dtsi. I am not sure how to handle the backwards compatible device tree breakage. Maybe since it's been around long enough, it might be ok. adam > > > > Can you please try catch the weird values or a failure maybe with > > > something like: > > > > > > while true; do > > > cat /sys/kernel/debug/mmc0/ios > > > fdisk -l /dev/mmcblk0 > > > cat /sys/kernel/debug/mmc0/ios > > > sleep 20 > > > done > > > > It appears the first time, that runs after fdisk, the values seems > > reasonable, but subsequent iterations, the values are zero again: > > Seems expected to me. Before fdisk -l the mmc controller may have > autoidled showing mostly zero values, and after any access to the mmc > card the card is enabled and the values are the normal enabled values. > > If, however, fdisk -l does not work, or the values right after fdisk -l > are mostly zero, then that would indicate a problem. I guess leaving > out the reading of ios before fdisk -l would make it easier to see. > > Regards, > > Tony
