On Fri, Nov 10, 2023 at 12:10:34PM +0100, Krzysztof Kozlowski wrote:
> On 10/11/2023 06:41, Drew Fustini wrote:
> > Add node for the SDHCI fixed clock. Add mmc0 node for the first mmc
> > controller instance which is typically connected to the eMMC device.
> > Add mmc1 node for the second mmc controller instance which is typically
> > connected to microSD slot.
> >
> > Signed-off-by: Drew Fustini <dfustini@xxxxxxxxxxxx>
> > ---
> > arch/riscv/boot/dts/thead/th1520.dtsi | 23 +++++++++++++++++++++++
> > 1 file changed, 23 insertions(+)
> >
> > diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi
> > index ff364709a6df..f5ec9326c4b8 100644
> > --- a/arch/riscv/boot/dts/thead/th1520.dtsi
> > +++ b/arch/riscv/boot/dts/thead/th1520.dtsi
> > @@ -134,6 +134,13 @@ uart_sclk: uart-sclk-clock {
> > #clock-cells = <0>;
> > };
> >
> > + sdhci_clk: sdhci-clock {
> > + compatible = "fixed-clock";
> > + clock-frequency = <198000000>;
> > + clock-output-names = "sdhci_clk";
> > + #clock-cells = <0>;
> > + };
> > +
> > soc {
> > compatible = "simple-bus";
> > interrupt-parent = <&plic>;
> > @@ -292,6 +299,22 @@ dmac0: dma-controller@ffefc00000 {
> > status = "disabled";
> > };
> >
> > + mmc0: mmc@ffe7080000 {
> > + compatible = "thead,th1520-dwcmshc";
> > + reg = <0xff 0xe7080000 0x0 0x10000>;
> > + interrupts = <62 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&sdhci_clk>;
> > + clock-names = "core";
>
> You miss disable in each mmc node.
>
> Best regards,
> Krzysztof
Thank you for reviewing. I will add 'status = "disabled"' to each node.
Drew
>
